ntlmrelayx.py: Hide unnecessary 'Unsupported MechType' log messages #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rtpt-erikgeiser, Looked for that same logging in other files and found Can be updated as well to align everything |
gabrielg5
added
the
waiting for response
rtpt-erikgeiser
force-pushed
the
fix_unsupported_mechtype_log_level
branch
from
a54edd8 to
38bbf77
Compare
|
Thanks for the review, I changed the line in |
gabrielg5
removed
the
waiting for response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the log level for
Unsupported MechTypemessages fromCRITICALtoDEBUG. These messages occur almost exclusively during SMB authentication when the counterpart prefers Kerberos over NTLM. I think there is no reason that these messages should be displayed outside of debug mode because they imply that something is wrong when rejecting the Kerberos preference is perfectly normal when NTLM is negotiated.